build

roles/puppet-agent/tasks/main.yml

@@ -1,4 +1,4 @@
-- name: Install puppet agent 
+- name: Install puppet agent
   become: "{{ false if inventory_hostname == 'nas.home.lan' else true }}"
   vars:
     puppet_server: active.home.lan
@@ -12,18 +12,18 @@
       ansible.builtin.setup:
       when: ansible_facts.architecture is not defined
     - name: Install Puppet agent package
-      package:
+      ansible.builtin.package:
         name: puppet-agent
         state: present
 
     - name: Create Puppet configuration directory
-      file:
+      ansible.builtin.file:
         path: /etc/puppetlabs/puppet
         state: directory
         mode: '0755'
 
     - name: Deploy puppet.conf
-      template:
+      ansible.builtin.template:
         src: puppet.conf.j2
         dest: /etc/puppet/puppet.conf
         owner: root
@@ -31,15 +31,16 @@
         mode: '0644'
 
     - name: Enable and start puppet agent
-      systemd:
+      ansible.builtin.systemd:
         name: puppet
         enabled: true
         state: started
 
-    - name: Trigger puppet agent run once1
+    - name: Trigger puppet agent run once
-      command: /usr/bin/puppet agent -t
+      ansible.builtin.command: /usr/bin/puppet agent -t
       register: puppet_run
-      ignore_errors: true
+      changed_when: puppet_run.rc != 0
 
-    - debug:
+    - name: Debug puppet run output
-        var: puppet_run.stdout_lines
+      ansible.builtin.debug:
+        var: puppet_run.stdout_lines