alias

roles/monitoring/tasks/main.yml

@@ -2,7 +2,7 @@
   ansible.builtin.set_fact:
     zabbix_agent_cfg: "/etc/zabbix/zabbix_agent2.conf"
   when: inventory_hostname != 'nas.home.lan'
-  
+
 - name: Get config for nas
   ansible.builtin.set_fact:
     zabbix_agent_cfg: "/opt/ZabbixAgent/etc/zabbix_agentd.conf"
@@ -29,42 +29,43 @@
   become: true
 - name: Install a .deb package from the internet2
   ansible.builtin.apt:
-    #deb: https://repo.zabbix.com/zabbix/6.4/raspbian/pool/main/z/zabbix-release/zabbix-release_6.4-1+debian11_all.deb
+    # deb: https://repo.zabbix.com/zabbix/6.4/raspbian/pool/main/z/zabbix-release/zabbix-release_6.4-1+debian11_all.deb
     deb: https://repo.zabbix.com/zabbix/7.0/raspbian/pool/main/z/zabbix-release/zabbix-release_7.0-1+debian11_all.deb
   retries: 5
   delay: 5
   when:
     - ansible_facts.architecture == "armv7l" or ansible_facts.architecture == "aarch64"
   become: true
-  ignore_errors: true
+  failed_when: my_output.rc != 0
 
 - name: Install a .deb package from the internet3
   ansible.builtin.apt:
     deb: https://repo.zabbix.com/zabbix/6.4/debian/pool/main/z/zabbix-release/zabbix-release_6.4-1+debian11_all.deb
-  become: true  
+  become: true
   when:
     - ansible_facts.architecture != "armv7l"  and ansible_distribution == "Debian"  and ansible_distribution_major_version  == "11"
-  
+
 - name: Install a .deb package from the internet4
   ansible.builtin.apt:
-    #deb: https://repo.zabbix.com/zabbix/6.4/debian/pool/main/z/zabbix-release/zabbix-release_6.4-1+debian12_all.deb
+    # deb: https://repo.zabbix.com/zabbix/6.4/debian/pool/main/z/zabbix-release/zabbix-release_6.4-1+debian12_all.deb
     deb: https://repo.zabbix.com/zabbix/7.2/debian/pool/main/z/zabbix-release/zabbix-release_7.2-1+debian12_all.deb
   when:
-    - ansible_facts.architecture != "armv7l" and  ansible_facts.architecture != "aarch64" and ansible_distribution == "Debian"  and ansible_distribution_major_version  == "12"
-  ignore_errors: true
+    - ansible_facts.architecture != "armv7l"
+    - ansible_facts.architecture != "aarch64"
+    - ansible_distribution == "Debian"
+    - ansible_distribution_major_version  == "12"
+  failed_when: my_output.rc != 0
   become: true
-# - name: Install a .deb package localy
-#   ansible.builtin.apt:
-#     deb: /tmp/zabbix-release_6.4-1+ubuntu22.04_all.deb
+
 - name: Install zabbix packages
   ansible.builtin.apt:
-    name: 
+    name:
       - zabbix-agent2
       - zabbix-agent2-plugin-mongodb
       - zabbix-agent2-plugin-postgresql
-    update_cache: yes
+    update_cache: false
   become: "{{ false if inventory_hostname == 'nas.home.lan' else true }}"
-  ignore_errors: true
+  failed_when: my_output.rc != 0
   when: inventory_hostname != 'nas.home.lan'
 
 - name: Reconfigure zabbix agent Server
@@ -99,14 +100,14 @@
     regexp: "^Hostname=.*"
     line: "Hostname={{ inventory_hostname }}"
   become: "{{ false if inventory_hostname == 'nas.home.lan' else true }}"
-  
+
 - name: Reconfigure zabbix-agent2 config
   ansible.builtin.lineinfile:
     path: "{{ zabbix_agent_cfg }}"
     insertafter: '^# UserParameter='
     regexp: "^UserParameter=system.certs.*"
     line: "UserParameter=system.certs,python3 /share/ZFS530_DATA/.qpkg/ZabbixAgent/cert_check2.py"
-  when: inventory_hostname == 'nas.home.lan' 
+  when: inventory_hostname == 'nas.home.lan'
   become: "{{ false if inventory_hostname == 'nas.home.lan' else true }}"
 
 - name: Reconfigure zabbix-agent2 config
@@ -115,7 +116,7 @@
     insertafter: '^# UserParameter='
     regexp: "^UserParameter=system.certs.*"
     line: "UserParameter=system.certs,python3 /usr/bin/cert_check2.py"
-  when: inventory_hostname == 'm-server.home.lan' 
+  when: inventory_hostname == 'm-server.home.lan'
   become: "{{ false if inventory_hostname == 'nas.home.lan' else true }}"
 
 - name: Reconfigure zabbix-agent2 config
@@ -140,14 +141,14 @@
     regexp: "^HostMetadata=.*"
     insertafter: '^# HostMetadata='
     line: "HostMetadata=server;jaydee"
-  when: inventory_hostname == 'nas.home.lan' or inventory_hostname == 'm-server.home.lan' 
+  when: inventory_hostname == 'nas.home.lan' or inventory_hostname == 'm-server.home.lan'
   become: "{{ false if inventory_hostname == 'nas.home.lan' else true }}"
 
 - name: Add the user 'to group video
   ansible.builtin.user:
     name: zabbix
     groups: video
-    append: yes
+    append: true
   when: inventory_hostname != 'nas.home.lan'
   become: "{{ false if inventory_hostname == 'nas.home.lan' else true }}"
 
@@ -160,6 +161,8 @@
   become: "{{ false if inventory_hostname == 'nas.home.lan' else true }}"
 
 - name: Restart agent
-  ansible.builtin.shell: /etc/init.d/ZabbixAgent.sh restart
+  ansible.builtin.command: /etc/init.d/ZabbixAgent.sh restart
   when: inventory_hostname == 'nas.home.lan'
-  become: "{{ false if inventory_hostname == 'nas.home.lan' else true }}"
+  changed_when: my_output.rc != 0
+  become: "{{ false if inventory_hostname == 'nas.home.lan' else true }}"
+